Skip to content

Conversation

@keith
Copy link
Member

@keith keith commented Oct 21, 2020

This is analogous to bazelbuild/bazel@bc5883a

It leads to more hermetic binaries and shouldn't have any impact on
debugging.

This is analogous to bazelbuild/bazel@bc5883a

It leads to more hermetic binaries and shouldn't have any impact on
debugging.
@google-cla google-cla bot added the cla: yes label Oct 21, 2020
@keith keith marked this pull request as ready for review October 21, 2020 21:25
@keith keith merged commit 320d0a3 into master Oct 22, 2020
@keith keith deleted the ks/add-swiftremap_xcode_path-feature branch October 22, 2020 17:48
@thii
Copy link
Member

thii commented Oct 27, 2020

What happens if -debug-prefix-map is passed more than once and they all match? Does the order matter?

@keith
Copy link
Member Author

keith commented Oct 27, 2020

Looks like only the first path matches https://github.com/llvm/llvm-project/blob/0c15a1b4bcefc1eb434e07aa31b7a08109ccd27e/clang/lib/CodeGen/CGDebugInfo.cpp#L479-L489

@keith
Copy link
Member Author

keith commented Oct 27, 2020

Also see bazelbuild/bazel#12354

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants